Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Cli.php #4342

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Create Cli.php #4342

wants to merge 1 commit into from

Conversation

vorpentine
Copy link

Added cli output, take or leave it.

This is:

  • [Y] a new feature

Checklist:

  • [?] Changes are covered by unit tests
    • [?] Changes are covered by existing unit tests
    • [?] New unit tests have been added
  • [Y] Code style is respected
  • [Y] Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • [N] CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • [N] Documentation is updated as necessary

Why this change is needed?

Handy for developers

Add cli ouput
@oleibman
Copy link
Collaborator

oleibman commented Feb 6, 2025

Your explanation is very vague. Could you give us a better idea of what you are trying to accomplish?

Aside from that, you will need to clean up the php-cs-fixer, phpcs, and phpstan problems. And add test cases. The only reason your change passes the CI tests is because your new code is never actually exercised. If it had been, you would certainly have run into errors when trying to call the no-longer-existing getCellByColumnAndRow method (a problem which phpstan flags).

For now, I am putting this change in draft status.

@oleibman oleibman marked this pull request as draft February 6, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants